NUMA xapi changes #6739
NUMA xapi changes #6739
Conversation
Signed-off-by: Christian Lindig <christian.lindig@citrix.com>
| | Some x -> | ||
| List.assoc "featureset" x.VmExtra.persistent.platformdata | ||
| ) | ||
| ; numa_optimised= false |
There was a problem hiding this comment.
This is the place where we would pick up the actual values from Xen.
cplaursen
force-pushed
the
NUMA-fields
branch
from
1e39065 to
71a4352
Compare
|
Is |
This commit adds three fields to VM_metrics: - numa_optimised: bool - whether a VM is optimised for NUMA - numa_nodes: int - number of NUMA nodes associated with VM - numa_node_memory: Map(int, int) - amount of VM memory in NUMA node X Signed-off-by: Christian Pardillo Laursen <christian.pardillolaursen@citrix.com>
Signed-off-by: Christian Pardillo Laursen <christian.pardillolaursen@citrix.com>
Signed-off-by: Christian Pardillo Laursen <christian.pardillolaursen@citrix.com>
cplaursen
force-pushed
the
NUMA-fields
branch
from
71a4352 to
45c7f8d
Compare
|
Forgot to bump schema minor version |
|
VM.numa_nodes can be less than length(VM_metrics.numa_node_memory) when the VM memory is optimised. For instance, in a host with 2 numa nodes, if VM.numa_nodes=1 then the VM memory is optimised to use 1 numa node of the host. It's convenient for the API client to have this number in a field instead of having to figure out how to calculate it from the contents of VM_metrics.numa_node_memory. |
|
Would suggest to merge this; given that it's a feature branch we need to look after it and rebase frequently. |
4 participants
This pull request adds three fields to the datamodel, as per the NUMA design sketch:
VM_metrics.numa_optimised: boolean: if the VM isoptimised for NUMA
VM_metrics.numa_nodes: integer: number of NUMA nodes of the hostthe VM is using
VM_metrics.numa_node_memory: int -> int map; mapping a NUMA node(int) to an amount of memory (bytes) in that node.
There are also updates to the CLI to expose these under xe vm-param-get param-name={numa-optimised, numa-nodes, numa-node-memory}.