Open
Conversation
TonioF
requested changes
Apr 21, 2023
Contributor
TonioF
left a comment
TonioF
left a comment
There was a problem hiding this comment.
Two changes regarding the documentation requested. My biggest problem here is to validate it. Can you add a test or a notebook?
Co-authored-by: Tonio Fincke <tonio.fincke@brockmann-consult.de>
Contributor
Can you still do this to show how to use this new parameter? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new parameter
extra_search_paramshas been added theCubeConfigas well as to the data store'sopen_data()method.The value of
extra_search_paramsis a dictionary that defines additional search parameters when querying the individual observations (time slices) that will form the data cube. Examples for such parameters are the keys"filter","filter-lang", or"fields". More on this can be found in the Sentinel Hub Catalog API documentation.Note that
extra_search_paramswill be ignored iftime_periodis used(i.e., given and not
None).Closes #93.