Conversation
pont-us
approved these changes
Jan 29, 2026
Member
pont-us
left a comment
There was a problem hiding this comment.
Looks good! I just added some comments and additional version restrictions as suggestions. I haven't tested with non-RSA algorithms either, but evidently this was not needed so far anyway. Either way, get_algorithm_by_name seems like a cleaner way to implement the current functionality.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1199 +/- ##
==========================================
- Coverage 89.55% 89.54% -0.01%
==========================================
Files 280 280
Lines 21653 21655 +2
==========================================
Hits 19391 19391
- Misses 2262 2264 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Co-authored-by: Pontus Lurcock <pontus.lurcock@brockmann-consult.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1191 . The issue was that the cryptography package is declared an optional dependency of pyjwt (which is a required xcube package) and a required dependency of moto (which is a dev only dependency of xcube). In consequence, all xcube developers had this package installed and did not stumble across this issue.
I added cryptography as xcube dependency, because apparently so far we relied in the code on its presence. However, I also removed the explicit call of a specific algorithm from xcubeto prevent such situations. If I see it correctly, the code would also work with other (i.e., non-RSA) algorithms, but I did not test this.
Checklist:
* [ ] Add unit tests and/or doctests in docstrings* [ ] Add docstrings and API docs for any new/modified user-facing classes and functions* [ ] New/modified features documented indocs/source/*CHANGES.md