test against color values rather than encoded string#1200
Merged
Conversation
forman
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix failing xcube tests. I assume that the problem is that so far we tested against base64-encoded strings, which might differ over time. I changed the tests so that first the strings are decoded back to color values before assertion.
Checklist:
* [ ] Add unit tests and/or doctests in docstrings* [ ] Add docstrings and API docs for any new/modified user-facing classes and functions* [ ] New/modified features documented indocs/source/** [ ] Changes documented inCHANGES.md