Skip to content

Conversation

@waruqi
Copy link
Member

@waruqi waruqi commented Jan 5, 2026

@waruqi waruqi added this to the v3.0.7 milestone Jan 5, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new "package scheme" system within Xmake, providing a more extensible and structured way to manage how packages are sourced, configured, and integrated. It refactors the core package loading logic to incorporate these new schemes and updates configuration inheritance to leverage the new package-centric approach, ultimately enhancing the flexibility and customizability of package management.

Highlights

  • Introduction of Package Schemes: A new scheme module has been added, enabling the definition and management of custom download and configuration schemes for packages, enhancing flexibility in package sourcing and integration.
  • Refactored Package Loading Logic: The core package loading mechanism in package.lua has been updated to explicitly load both components and the newly introduced schemes, streamlining the initialization process.
  • Enhanced Configuration Inheritance: The extraconf method in component.lua now correctly delegates to the parent package for retrieving extra configurations, aligning with the new scheme-based hierarchical structure.
  • New Scheme-Specific APIs: A comprehensive set of APIs (e.g., scheme.set_urls, scheme.add_patches, scheme.add_versions) has been introduced within the scheme module to allow detailed configuration of individual package schemes.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces package schemes, a new feature for customizing package handling. The implementation adds a new scheme.lua module and integrates it into package.lua. The changes are mostly well-structured.

However, I've noticed a couple of issues:

  1. In xmake/core/package/package.lua, there's a logic issue in schemes_orderlist() which I've commented on.
  2. The refactoring in xmake/core/package/package.lua (moving logic into _load()) has made some code in xmake/modules/private/action/require/impl/package.lua in the _load_package function redundant and buggy. The calls to load components and environments are now duplicated, and package:envs_load() has been renamed, which will cause an error. These redundant calls should be removed to fix the bug and clean up the code.

@waruqi waruqi force-pushed the scheme branch 2 times, most recently from 1ebd53f to 4542ea8 Compare January 9, 2026 12:50
@waruqi waruqi marked this pull request as ready for review January 9, 2026 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants