-
-
Notifications
You must be signed in to change notification settings - Fork 901
Add package schemes #7189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Add package schemes #7189
Conversation
Summary of ChangesHello @waruqi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new "package scheme" system within Xmake, providing a more extensible and structured way to manage how packages are sourced, configured, and integrated. It refactors the core package loading logic to incorporate these new schemes and updates configuration inheritance to leverage the new package-centric approach, ultimately enhancing the flexibility and customizability of package management. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces package schemes, a new feature for customizing package handling. The implementation adds a new scheme.lua module and integrates it into package.lua. The changes are mostly well-structured.
However, I've noticed a couple of issues:
- In
xmake/core/package/package.lua, there's a logic issue inschemes_orderlist()which I've commented on. - The refactoring in
xmake/core/package/package.lua(moving logic into_load()) has made some code inxmake/modules/private/action/require/impl/package.luain the_load_packagefunction redundant and buggy. The calls to load components and environments are now duplicated, andpackage:envs_load()has been renamed, which will cause an error. These redundant calls should be removed to fix the bug and clean up the code.
1ebd53f to
4542ea8
Compare
#7184