Conversation
|
This PR is part of a stack of 4 bookmarks:
Created with jj-stack |
|
Claude finished @insipx's task —— View job Code Review - February 4, 2026 21:20 UTC
Review FindingsCritical Issue: Type mismatch in In impl Endpoint for FetchD14nCutover {
type Output = FetchD14nCutover; // ❌ Wrong - should be FetchD14nCutoverResponseThis should be: type Output = FetchD14nCutoverResponse;Why this matters:
Proto Cache Enhancement: The Minor: Test Coverage The ignored test is understandable since the service isn't implemented yet. Consider adding a non-ignored test similar to |
Add
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## push-qqtpmktputny #3118 +/- ##
=====================================================
+ Coverage 74.11% 74.21% +0.09%
=====================================================
Files 448 449 +1
Lines 55717 55741 +24
=====================================================
+ Hits 41297 41367 +70
+ Misses 14420 14374 -46 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
268c3c8 to
f014a8d
Compare
0ea43ea to
26d963d
Compare
| pub struct FetchD14nCutover; | ||
|
|
||
| impl Endpoint for FetchD14nCutover { | ||
| type Output = FetchD14nCutover; |
There was a problem hiding this comment.
🟡 Medium
d14n/fetch_d14n_cutover.rs:11 Output should be FetchD14nCutoverResponse, not FetchD14nCutover. This will cause deserialization failures when decoding the gRPC response.
| type Output = FetchD14nCutover; | |
| type Output = FetchD14nCutoverResponse; |
🚀 Want me to fix this? Reply ex: "fix it for me".
create an endpoint for the d14n cutover timestamp. closes #3031