Add fireblocks support for settlement chain upgrades

[KevinSmall]

Add Fireblocks-admin support and dynamic contract-name-based keys for settlement and app-chain upgrade scripts

Introduce environment-driven admin mode (PrivateKey or Fireblocks), add three-step settlement upgrade entrypoints, and switch migrator parameter keys and Fireblocks notes to use runtime contractName() values via FireblocksNote.

📍Where to Start

Start with admin mode selection and Fireblocks note generation in setUp() and helpers of BaseSettlementChainUpgrader and BaseAppChainUpgrader in script/upgrades/settlement-chain/BaseSettlementChainUpgrader.s.sol and script/upgrades/app-chain/BaseAppChainUpgrader.s.sol.

---

📊 Macroscope summarized be20684. 31 files reviewed, 1 issue evaluated, 0 issues filtered, 1 comment posted

🗂️ Filtered Issues

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

• 🔍 Trigger a full review

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch 12-19-scripts_add_fireblocks

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Changes to gas cost

Generated at commit: 9725fd6d34146159220daff7fae127bdfc48226c, compared to commit: 253037f388b24abce932af96e4391d2693db781e

🧾 Summary (20% most significant diffs)

Contract	Method	Avg (+/-)	%
Proxy	fallback initialize()	+3,588 ❌ +22,971 ❌	+0.63% +29.74%
PayerReportManagerUpgrader	isContractStateEqual	+48 ❌	+1.27%
RateRegistryUpgrader	isContractStateEqual	+31 ❌	+1.05%
PayerRegistryUpgrader	isContractStateEqual	+26 ❌	+0.49%

---

Full diff report 👇

Contract	Deployment Cost (+/-)	Method	Min (+/-)	%	Avg (+/-)	%	Median (+/-)	%	Max (+/-)	%	# Calls (+/-)
Proxy	105,099 (0)	__mint contractName fallback implementation initialize() migrate migratorParameterKey name parameterRegistry symbol version	56,427 (0) 5,265 (0) 4,971 (0) 5,135 (-10) 28,490 (0) 29,296 (-45) 5,310 (0) 7,987 (-62) 5,028 (0) 7,999 (-45) 5,287 (0)	0.00% 0.00% 0.00% -0.19% 0.00% -0.15% 0.00% -0.77% 0.00% -0.56% 0.00%	63,294 (+1,284) 5,303 (+9) 568,718 (+3,588) 5,156 (-7) 100,201 (+22,971) 32,746 (-23) 5,325 (+2) 8,018 (-31) 5,050 (+6) 8,021 (-23) 5,314 (+5)	+2.07% +0.17% +0.63% -0.14% +29.74% -0.07% +0.04% -0.39% +0.12% -0.29% +0.09%	56,439 (0) 5,308 (+21) 31,981 (-12) 5,156 (-11) 95,733 (0) 33,586 (-23) 5,330 (0) 8,018 (-31) 5,061 (+17) 8,021 (-23) 5,319 (+10)	0.00% +0.40% -0.04% -0.21% 0.00% -0.07% 0.00% -0.39% +0.34% -0.29% +0.19%	73,527 (0) 5,331 (+1) 2,861,555,004 (0) 5,179 (0) 145,712 (+49,979) 37,507 (0) 5,330 (0) 8,049 (0) 5,061 (0) 8,044 (0) 5,331 (0)	0.00% +0.02% 0.00% 0.00% +52.21% 0.00% 0.00% 0.00% 0.00% 0.00% 0.00%	52 (+6) 4 (+1) 15,945 (-117) 4 (+1) 138 (+48) 10 (+5) 4 (+1) 2 (+1) 6 (+2) 2 (+1) 4 (+1)
PayerReportManagerUpgrader	8,655,565 (+1,315,416)	getContractState isContractStateEqual	17,401 (+17) 3,842 (+48)	+0.10% +1.27%	17,401 (+17) 3,842 (+48)	+0.10% +1.27%	17,401 (+17) 3,842 (+48)	+0.10% +1.27%	17,401 (+17) 3,842 (+48)	+0.10% +1.27%	2 (0) 1 (0)
RateRegistryUpgrader	5,962,699 (+1,315,078)	getContractState isContractStateEqual	15,177 (+20) 2,977 (+31)	+0.13% +1.05%	15,177 (+20) 2,977 (+31)	+0.13% +1.05%	15,177 (+20) 2,977 (+31)	+0.13% +1.05%	15,177 (+20) 2,977 (+31)	+0.13% +1.05%	2 (0) 1 (0)
PayerRegistryUpgrader	8,649,783 (+1,310,196)	getContractState isContractStateEqual	27,755 (-11) 5,351 (+26)	-0.04% +0.49%	27,755 (-11) 5,351 (+26)	-0.04% +0.49%	27,755 (-11) 5,351 (+26)	-0.04% +0.49%	27,755 (-11) 5,351 (+26)	-0.04% +0.49%	2 (0) 1 (0)
SettlementChainGatewayUpgrader	7,672,250 (+1,314,040)	getContractState isContractStateEqual	17,531 (+17) 3,837 (+14)	+0.10% +0.37%	17,531 (+17) 3,837 (+14)	+0.10% +0.37%	17,531 (+17) 3,837 (+14)	+0.10% +0.37%	17,531 (+17) 3,837 (+14)	+0.10% +0.37%	2 (0) 1 (0)
FeeTokenUpgrader	7,447,671 (+1,310,077)	getContractState isContractStateEqual	26,434 (+18) 5,668 (+16)	+0.07% +0.28%	26,434 (+18) 5,668 (+16)	+0.07% +0.28%	26,434 (+18) 5,668 (+16)	+0.07% +0.28%	26,434 (+18) 5,668 (+16)	+0.07% +0.28%	2 (0) 1 (0)
SettlementChainParameterRegistryUpgrader	5,734,613 (+1,302,081)	getContractState	11,094 (+21)	+0.19%	11,094 (+21)	+0.19%	11,094 (+21)	+0.19%	11,094 (+21)	+0.19%	2 (0)
DistributionManagerUpgrader	8,047,069 (+1,314,417)	getContractState isContractStateEqual	25,150 (+12) 5,343 (+4)	+0.05% +0.07%	25,150 (+12) 5,343 (+4)	+0.05% +0.07%	25,150 (+12) 5,343 (+4)	+0.05% +0.07%	25,150 (+12) 5,343 (+4)	+0.05% +0.07%	2 (0) 1 (0)
NodeRegistryUpgrader	9,473,486 (+1,312,446)	getContractState	77,978 (+8)	+0.01%	77,978 (+8)	+0.01%	77,978 (+8)	+0.01%	77,978 (+8)	+0.01%	2 (0)

[github-actions]

LCOV of commit 9b03a32 during Solidity #669

Summary coverage rate:
  lines......: 99.9% (1332 of 1333 lines)
  functions..: 100.0% (381 of 381 functions)
  branches...: no data found

Files changed coverage rate: n/a