FEAT: auto batch embedding #4197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@llyycchhee please help me check this PR, and see if there's anything that can be improved. Benchmarks welcome. |
Contributor
Author
|
Can you paste some benchmark to illustrate the result? @llyycchhee |
qinxuye
commented
Nov 11, 2025
Contributor
Author
256 queries' benchmark. The improvements are huge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, embedding is sequential, though users could create multiple embeddings at same time.
After this PR, the model class could inherit
BatchMixin, and provides method with batch version (utilizing xoscar batch API), the request will be put into queue, and a background coroutine will collect items as many as possible and call API in a single call.This is an initial version of auto batching, actually, this could be applied to all models, not only for auto-regressive models(basically LLM).
Fixes #4123