Fix parameter forwarding for pwsh #399
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tusharb86
force-pushed
the
pwsh-parameter-forwarding-fix
branch
from
79d0601 to
a4e16e4
Compare
|
Hey @xt0rted! I'm eager to get this change merged and a new version published. Is there anything I can help with to get the process moving forward? Let me know if you have questions or concerns with this change. Thank you! |
|
Hey @xt0rted! When do you think you'll have a chance to review and get this one merged? Would we be able to do a release after it's in? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the pwsh script shell and trying to pass arguments after the double dash
--to an underlying PowerShell script, it did not like having the arguments escaped. Instead, in the pwsh case, specifically, we just concatenate the arguments to pass to the underlying command.Note that instead of modifying the existing branch for non-cmd shells in
CommandRunner.cs, I added a specific check forpwshto ensure this change does not affect other shells like bash/sh.See issue #398 for more context and a repro of the bug.