Open
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| std::lock_guard<std::mutex> lock(mutex_); | ||
| size_t pos = bs_._Find_next(kCiVCidStart - 1); | ||
| if (pos == bs_.size()) | ||
| if (pos == bs_.size()) |
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Line ends in whitespace. Consider deleting these extra spaces. [whitespace/end_of_line] [4]
yadong-intel
force-pushed
the
test_rd
branch
2 times, most recently
from
3252764 to
10544d1
Compare
| if (pos == bs_.size()) | ||
| return 0; | ||
| bs_.reset(pos); | ||
| bs_.reset (pos); |
There was a problem hiding this comment.
[cpplint] reported by reviewdog 🐶
Extra space before ( in function call [whitespace/parens] [4]
yadong-intel
force-pushed
the
bumpv1.2
branch
3 times, most recently
from
e52e16c to
bce17d0
Compare
Fix issues identidied by cpplint. Tracked-On: OAM-105393 Signed-off-by: Yadong Qi <yadong.qi@intel.com>
Add github action: reviewdog-cpplint Tracked-On: OAM-105393 Signed-off-by: Yadong Qi <yadong.qi@intel.com>
Bump version to 1.2.0 Tracked-On: OAM-105393 Signed-off-by: Yadong Qi <yadong.qi@intel.com>
Signed-off-by: Yadong Qi <yadong.qi@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Yadong Qi yadong.qi@intel.com