Open
Conversation
Owner
|
Thanks for the PR! It's really great and gave me much inspiration for the batch request API implementation of msgraph.go. msgraph.go respects and mimics the API designs and conventions of msgraph-sdk-dotnet to some extent, so we'd better refer microsoftgraph/msgraph-sdk-dotnet/pull/412 with regard to batch requests. Now I have a certain idea in my mind, but unfortunately I'm lacking time to explain details this week. I'm going to create an issue to dump it later, then please feel free telling what you think there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support batch operation. I have split the PR into two: one is the change on the templates, the other one is to update the code by regenerating them. You might only want to check out the first commit :)