[MAS-46399] Handling NPE on sync side#175
Open
dgupta03-byte wants to merge 1 commit intoyahoo:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Handling NPE on sync side
Motivation and Context
cleanup() is invoked from channelInactive() and sets processor = null. During Netty pipeline teardown, channelInactive() may be called on this handler before exceptionCaught() (for example, if a decompression error is reported later or handler ordering differs). As a result, exceptionCaught() can be invoked after cleanup has already run and observe processor == null.
The if (processor != null) guard ensures that we do not call handleChannelException() after cleanup has completed.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: