Skip to content

Fix issues #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yahyalmh wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix issues #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e0f2dfb
Change state to be immutable
yahyalmh Jan 25, 2023
fd59831
Decrease requests timeout
yahyalmh Jan 25, 2023
4b55916
Remove unnecessary tag
yahyalmh Jan 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions app/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,6 @@

<category android:name="android.intent.category.LAUNCHER" />
</intent-filter>

<meta-data
android:name="android.app.lib_name"
android:value="" />
</activity>
</application>

Expand Down
4 changes: 2 additions & 2 deletions data/common/src/main/java/com/example/data/common/api/di/NetworkModule.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ interface NetworkModule {
val logging = HttpLoggingInterceptor()
logging.setLevel(HttpLoggingInterceptor.Level.BODY)
OkHttpClient.Builder()
.readTimeout(60, TimeUnit.SECONDS)
.writeTimeout(60, TimeUnit.SECONDS)
.readTimeout(15, TimeUnit.SECONDS)
.writeTimeout(15, TimeUnit.SECONDS)
.addInterceptor(logging)
.build()
} else OkHttpClient.Builder().build()
Expand Down
4 changes: 2 additions & 2 deletions ui/common/src/main/java/com/example/ui/common/BaseViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ import androidx.lifecycle.ViewModel
*/

abstract class BaseViewModel<T : UIState, E : UIEvent>(initialState: T) : ViewModel() {
private var internalSate: MutableState<T> = mutableStateOf(initialState)
var state: State<T> = internalSate
private val internalSate: MutableState<T> = mutableStateOf(initialState)
val state: State<T> = internalSate

abstract fun onEvent(event: E)

Expand Down