Open
Conversation
okryukova
reviewed
Feb 20, 2026
|
|
||
| private int indexOld; | ||
| private int indexNew; | ||
| private int indexAfterMove0; |
There was a problem hiding this comment.
⛔️Нужно исправить. При нейминге не рекомендуется использовать числа (Field2), их еще называют magicNumbers. Очень тяжело поддерживать код с magicNumbers.
|
|
||
| } | ||
|
|
||
| @Parameterized.Parameters |
There was a problem hiding this comment.
okryukova
approved these changes
Feb 21, 2026
okryukova
reviewed
Feb 21, 2026
|
|
||
| @Test | ||
| @Description("Проверка удаления ингредиентов из бургера") | ||
| public void removeIngredientShouldDeleteIngredientFromBurgerTest() { |
There was a problem hiding this comment.
⛔️Нужно исправить. Тесты , где параметризация не нужна, необходимо вынести в отдельный класс
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Выполнено юнит-тестирование класса Burger.
Выполнены тесты:
Проверка установки булки, добавления и удаления ингредиентов.
Проверка перемещения ингредиентов с использованием параметризованных тестов.
Проверка расчета цены и генерации рецепта, включая сценарий без ингредиентов.
Используемые библиотеки:
JUnit 4 (запуск тестов),
Mockito (создание моков булок и ингредиентов для изоляции тестов)
JaCoCo (генерация отчета о покрытии кода тестами)
Тесты обеспечивают покрытие всех методов класса Burger.