Skip to content

Conversation

@Gazizonoki
Copy link
Collaborator

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a Dockerfile and build configuration for SLO (Service Level Objective) workloads in the C++ SDK. The changes enable building and running SLO workload tests in a containerized environment.

  • Adds a comprehensive Dockerfile that sets up the complete build environment with all required dependencies
  • Integrates CMake build configuration for SLO workload utilities and key-value test executable
  • Adds OpenTelemetry C++ library as a dependency for metrics collection

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
tests/slo_workloads/Dockerfile New Dockerfile that installs all build dependencies (LLVM, CMake, gRPC, protobuf, abseil, etc.) and builds the slo-key-value executable
tests/slo_workloads/CMakeLists.txt Top-level CMake file that includes key_value and utils subdirectories
tests/slo_workloads/utils/CMakeLists.txt CMake configuration for slo-utils library with OpenTelemetry metrics support
tests/slo_workloads/key_value/CMakeLists.txt CMake configuration for slo-key-value executable with platform-specific linking
tests/CMakeLists.txt Updated to include slo_workloads subdirectory in the build
cmake/testing.cmake Adds OpenTelemetry C++ v1.24.0 as a FetchContent dependency with appropriate configuration options
.gitignore Changed pattern from !.devcontainer/Dockerfile to !Dockerfile to unignore Dockerfiles
tests/slo_workloads/.dockerignore Removed the entire .dockerignore file that previously excluded various files from Docker context

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Gazizonoki Gazizonoki merged commit 9e4d583 into main Dec 24, 2025
35 of 36 checks passed
@Gazizonoki Gazizonoki deleted the add-slo-workload branch December 24, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants