-
Notifications
You must be signed in to change notification settings - Fork 17
feat: renderMonitoring to diagnostics #3032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| # See https://help.github.com/articles/ignoring-files/ for more about ignoring files. | ||
|
|
||
| # dependencies | ||
| /node_modules | ||
| /.pnp | ||
| .pnp.js | ||
|
|
||
| # testing | ||
| /coverage | ||
| playwright-artifacts | ||
|
|
||
| # production | ||
| /build | ||
| /dist | ||
| *.zip | ||
|
|
||
| # misc | ||
| .idea | ||
| .DS_Store | ||
| .env.local | ||
| .env.development.local | ||
| .env.test.local | ||
| .env.production.local | ||
| .vscode | ||
| .cursor | ||
|
|
||
| npm-debug.log* | ||
| yarn-debug.log* | ||
| yarn-error.log* | ||
|
|
||
| .env | ||
|
|
||
|
|
||
| embedded-ui.tar.bz2 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,6 +7,7 @@ import {TENANT_DIAGNOSTICS_TABS_IDS} from '../../../store/reducers/tenant/consta | |
| import type {TenantDiagnosticsTab} from '../../../store/reducers/tenant/types'; | ||
| import {EPathSubType, EPathType} from '../../../types/api/schema'; | ||
| import type {ETenantType} from '../../../types/api/tenant'; | ||
| import {uiFactory} from '../../../uiFactory/uiFactory'; | ||
| import type {TenantQuery} from '../TenantPages'; | ||
| import {TenantTabsGroups} from '../TenantPages'; | ||
| import {isDatabaseEntityType, isTopicEntityType} from '../utils/schema'; | ||
|
|
@@ -110,6 +111,11 @@ const operations = { | |
| title: 'Operations', | ||
| }; | ||
|
|
||
| const monitoring = { | ||
| id: TENANT_DIAGNOSTICS_TABS_IDS.monitoring, | ||
| title: 'Monitoring', | ||
| }; | ||
|
|
||
| const ASYNC_REPLICATION_PAGES = [overview, tablets, describe, access]; | ||
|
|
||
| const TRANSFER_PAGES = [overview, tablets, describe, access]; | ||
|
|
@@ -233,7 +239,14 @@ export const getPagesByType = ( | |
| const dbContext = isDatabaseEntityType(type) || options?.isTopLevel; | ||
| const seeded = dbContext ? getDatabasePages(options?.databaseType) : base; | ||
|
|
||
| return applyFilters(seeded, type, options); | ||
| const result = applyFilters(seeded, type, options); | ||
|
|
||
| // Add monitoring tab as second tab if renderMonitoring is available | ||
| if (uiFactory.renderMonitoring) { | ||
| result.splice(1, 0, monitoring); | ||
| } | ||
|
Comment on lines
+245
to
+247
|
||
|
|
||
| return result; | ||
| }; | ||
|
|
||
| export const useDiagnosticsPageLinkGetter = () => { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems this check should be in
getDatabasePages.