Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 34 additions & 0 deletions .rooignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
# See https://help.github.com/articles/ignoring-files/ for more about ignoring files.

# dependencies
/node_modules
/.pnp
.pnp.js

# testing
/coverage
playwright-artifacts

# production
/build
/dist
*.zip

# misc
.idea
.DS_Store
.env.local
.env.development.local
.env.test.local
.env.production.local
.vscode
.cursor

npm-debug.log*
yarn-debug.log*
yarn-error.log*

.env


embedded-ui.tar.bz2
11 changes: 11 additions & 0 deletions src/containers/Tenant/Diagnostics/Diagnostics.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,17 @@ function Diagnostics({additionalTenantProps}: DiagnosticsProps) {
scrollContainerRef: containerRef,
});
}
case TENANT_DIAGNOSTICS_TABS_IDS.monitoring: {
return uiFactory.renderMonitoring?.({
type,
subType,
database,
path,
databaseFullPath,
additionalTenantProps,
scrollContainerRef: containerRef,
});
}
default: {
return <div>{i18n('no-data')}</div>;
}
Expand Down
15 changes: 14 additions & 1 deletion src/containers/Tenant/Diagnostics/DiagnosticsPages.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import {TENANT_DIAGNOSTICS_TABS_IDS} from '../../../store/reducers/tenant/consta
import type {TenantDiagnosticsTab} from '../../../store/reducers/tenant/types';
import {EPathSubType, EPathType} from '../../../types/api/schema';
import type {ETenantType} from '../../../types/api/tenant';
import {uiFactory} from '../../../uiFactory/uiFactory';
import type {TenantQuery} from '../TenantPages';
import {TenantTabsGroups} from '../TenantPages';
import {isDatabaseEntityType, isTopicEntityType} from '../utils/schema';
Expand Down Expand Up @@ -110,6 +111,11 @@ const operations = {
title: 'Operations',
};

const monitoring = {
id: TENANT_DIAGNOSTICS_TABS_IDS.monitoring,
title: 'Monitoring',
};

const ASYNC_REPLICATION_PAGES = [overview, tablets, describe, access];

const TRANSFER_PAGES = [overview, tablets, describe, access];
Expand Down Expand Up @@ -233,7 +239,14 @@ export const getPagesByType = (
const dbContext = isDatabaseEntityType(type) || options?.isTopLevel;
const seeded = dbContext ? getDatabasePages(options?.databaseType) : base;

return applyFilters(seeded, type, options);
const result = applyFilters(seeded, type, options);

// Add monitoring tab as second tab if renderMonitoring is available
if (uiFactory.renderMonitoring) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems this check should be in getDatabasePages.

result.splice(1, 0, monitoring);
}
Comment on lines +245 to +247
Copy link

Copilot AI Oct 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The monitoring tab is unconditionally inserted at position 1 (second tab) for all entity types, which could disrupt the expected tab order. Unlike the backups tab which is added to predefined page arrays and filtered through applyFilters, this approach bypasses the existing filtering logic and may insert the monitoring tab even when it doesn't make sense for certain entity types. Consider either: (1) adding monitoring to the relevant page arrays (e.g., DATABASE_PAGES, SERVERLESS_DATABASE_PAGES) and using an option-based filter similar to hasBackups, or (2) adding conditional logic to check entity type/context before insertion.

Copilot uses AI. Check for mistakes.

return result;
};

export const useDiagnosticsPageLinkGetter = () => {
Expand Down
1 change: 1 addition & 0 deletions src/store/reducers/tenant/constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ export const TENANT_DIAGNOSTICS_TABS_IDS = {
operations: 'operations',
access: 'access',
backups: 'backups',
monitoring: 'monitoring',
} as const;

export const TENANT_SUMMARY_TABS_IDS = {
Expand Down
14 changes: 13 additions & 1 deletion src/uiFactory/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,9 @@ import type {
import type {ClusterInfo} from '../store/reducers/cluster/cluster';
import type {IssuesTree} from '../store/reducers/healthcheckInfo/types';
import type {PreparedTenant} from '../store/reducers/tenants/types';
import type {ClusterLink, DatabaseLink} from '../types/additionalProps';
import type {AdditionalTenantsProps, ClusterLink, DatabaseLink} from '../types/additionalProps';
import type {MetaBaseClusterInfo} from '../types/api/meta';
import type {EPathSubType, EPathType} from '../types/api/schema/schema';
import type {ETenantType} from '../types/api/tenant';
import type {GetLogsLink} from '../utils/logs';
import type {GetMonitoringClusterLink, GetMonitoringLink} from '../utils/monitoring';
Expand All @@ -35,6 +36,7 @@ export interface UIFactory<H extends string = CommonIssueType> {

renderBackups?: RenderBackups;
renderEvents?: RenderEvents;
renderMonitoring?: RenderMonitoring;
clusterOrDatabaseAccessError?: Partial<EmptyStateProps>;

healthcheck: {
Expand Down Expand Up @@ -85,3 +87,13 @@ export type RenderBackups = (props: {
export type RenderEvents = (props: {
scrollContainerRef: React.RefObject<HTMLDivElement>;
}) => React.ReactNode;

export type RenderMonitoring = (props: {
type?: EPathType;
subType?: EPathSubType;
database: string;
path: string;
databaseFullPath?: string;
additionalTenantProps?: AdditionalTenantsProps;
scrollContainerRef: React.RefObject<HTMLDivElement>;
}) => React.ReactNode;
Loading