[codex] add yield splitter vault metadata#386
Draft
rossgalloway wants to merge 2 commits intomainfrom
Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Add
yieldSplittermetadata to vault responses across the web API.This includes:
Vault.yieldSplitterWhy
Clients need a structured way to identify yield-splitter vaults and render their source vault, target vault, reward token, and strategy metadata.
The follow-up work on this branch also fixes review issues uncovered during implementation:
Impact
yieldSplitterfromVaultRoot cause
Yield-splitter metadata was not previously modeled in the web API, so clients had no typed way to distinguish these vaults or understand their vault-to-vault routing.
Validation
bun testinpackages/webbunx tsc -p tsconfig.json --noEmitinpackages/webbun run lintinpackages/webLint still shows the pre-existing warning in
packages/web/components/LatestBlocks.tsxfor an unusedindexvariable.