Skip to content

Conversation

@gerdemann
Copy link

No description provided.

bwaidelich
bwaidelich previously approved these changes Apr 14, 2022
Copy link
Collaborator

@bwaidelich bwaidelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good (by reading)

albe
albe previously approved these changes Apr 14, 2022
Copy link

@albe albe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fully agree to what Bastian wrote in the old PR. Reads good from what I can see. Thanks a lot for taking it up!

@gerdemann gerdemann dismissed stale reviews from albe and bwaidelich via a9e77f4 April 14, 2022 10:00
Co-authored-by: Alexander Berl <a.berl@outlook.com>
Copy link

@Benjamin-K Benjamin-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and can be merged, IMO.

Copy link

@Benjamin-K Benjamin-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sry, forgot to check viewed files...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants