The best Parser.java you ever seen #452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

neogeogre wants to merge 2 commits into yegor256:master from neogeogre:master

neogeogre commented Oct 20, 2020 •

edited

Loading

choices

Keep minimal amount of code
Keep nesting as flat as possible
Try to have sefl explanatory code (remove comments)
Use wisely var and -> synthax
A single null check preserves the whole Object
Delegate exception handling
Remove code duplication
Remove useless accessors with immutability and public property
Don't touch public methods names, PO requirements ?
I don't speak php

todo

Find a better lib than java.util.stream
Test it
Rethink the weird behaviors

Geoffrey Vincent added 2 commits

October 20, 2020 22:52


          Update Parser.java

0dae2ec


          better if closes

d394593

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet