Open
Conversation
Author
|
@yegor256 Hi! I've made my first Java contribution. Could please review my PR? I'm new to Java development, so any feedback would be greatly appreciated! |
yegor256
reviewed
Nov 25, 2025
| new FkRegex("/d", new TkDetails(base)), | ||
| new FkRegex( | ||
| "/d", | ||
| new TkNotFoundSafeDetails( |
Owner
There was a problem hiding this comment.
@blablatdinov what if something similar happens in the TkInfo? We won't render the "not found" page.
yegor256
reviewed
Nov 25, 2025
| public Response act(final Request req) throws IOException { | ||
| try { | ||
| return this.origin.act(req); | ||
| } catch (final IOException ex) { |
Owner
There was a problem hiding this comment.
@blablatdinov this is too harsh. Treating I/O error (for example, disk is full) as not-found problem is not accurate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.