feat: add LlamaIndex integration with hybrid retriever support (#217)#274
Open
ArshadJafri wants to merge 1 commit intoyichuan-w:mainfrom
Open
feat: add LlamaIndex integration with hybrid retriever support (#217)#274ArshadJafri wants to merge 1 commit intoyichuan-w:mainfrom
ArshadJafri wants to merge 1 commit intoyichuan-w:mainfrom
Conversation
Collaborator
|
LGTM @ArshadJafri Thanks for this integration — the implementation looks good. Verified:
Minor suggestions (before merging):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements LlamaIndex integration for LEANN, requested in #217 and addressing integration blockers discovered previously.
What was built
We introduced two
BaseRetrieversubclasses:Key Fixes Included
0.3) to LEANN's underlying vector-weight parametergemma.metadatainto strict dictionaries before casting them to LlamaIndexNodeWithScoreobjects. This natively prevents crashes when users wrap this inside LlamaIndex'sQueryFusionRetriever.Testing
gemmatranslation mathematics.