Fix test assertions to match SymfonyStyle confirm prompt format#325
Merged
samdark merged 4 commits into319-better-confirmfrom Feb 22, 2026
Merged
Fix test assertions to match SymfonyStyle confirm prompt format#325samdark merged 4 commits into319-better-confirmfrom
samdark merged 4 commits into319-better-confirmfrom
Conversation
Co-authored-by: samdark <47294+samdark@users.noreply.github.com>
Contributor
Author
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot
AI
changed the title
[WIP] Update confirmation style based on feedback from PR #324
Fix test assertions to match SymfonyStyle confirm prompt format
Feb 22, 2026
samdark
approved these changes
Feb 22, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 319-better-confirm #325 +/- ##
=========================================================
+ Coverage 11.76% 99.68% +87.92%
Complexity 293 293
=========================================================
Files 20 20
Lines 952 952
=========================================================
+ Hits 112 949 +837
+ Misses 840 3 -837 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Updates the migration command tests to align with the confirmation prompt format produced by SymfonyStyle::confirm() (via Symfony’s question helper), replacing the legacy y/n:-style expectations.
Changes:
- Adjusted two output assertions to expect the
ConfirmationQuestionprompt format (? (yes/no) [yes]:). - Keeps
UpdateCommandbehavior unchanged; this is strictly a test expectation update.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UpdateCommandwas updated to useSymfonyStyle::confirm(), but the tests still asserted against the oldQuestionHelper-style prompt (y/n:).SymfonyStyledelegates toSymfonyQuestionHelper, which renders confirmation prompts differently.Changes
tests/Common/Command/AbstractUpdateCommandTest.php: Updated two assertions to match the actualSymfonyQuestionHelperoutput format:'Apply the above migration y/n:'→'Apply the above migration? (yes/no) [yes]:''Apply the above migrations y/n:'→'Apply the above migrations? (yes/no) [yes]:'The new format is produced by
SymfonyQuestionHelper::writePrompt()forConfirmationQuestionwithdefault = true:🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.