Closed
Conversation
I added this ages back in response to a crash, when I laboured under the incorrect belief that Lua allows opcode sequences to changed. It doesn't. The fact that this once fixed a crash is a pure coincidence! Notice also that this comment is wrong: > Thus if two `Proto`s are allocated -- at different times! -- at the > same address `yk_idempotent`, by definition, is only in the context of a given `Location` and trace: it can't return different values given this context. This is a small but measurable speed-up for benchmarks that spend a reasonable amount of time in the interpreter.
Contributor
|
Deleting code is good! |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
Author
|
Thank goodness for CI! I now see something like this is necessary to ensure Lua-level inlining is stable. I'll close this in favour of a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added this ages back in response to a crash, when I laboured under the incorrect belief that Lua allows opcode sequences to changed. It doesn't. The fact that this once fixed a crash is a pure coincidence!
Notice also that this comment is wrong:
yk_idempotent, by definition, is only in the context of a givenLocationand trace: it can't return different values given this context.This is a small but measurable speed-up for benchmarks that spend a reasonable amount of time in the interpreter.