Merged
Conversation
vext01
commented
Mar 17, 2026
py/runtime.c
Outdated
|
|
||
| mp_obj_t MICROPY_WRAP_MP_BINARY_OP(mp_binary_op)(mp_binary_op_t op, mp_obj_t lhs, mp_obj_t rhs) { | ||
| // NOTE: this annotation makes bigloop and CLBG fannkuch Python3 #8 faster, but | ||
| // makes Laurie's mandelbrot (XXX where did he get it?) slower. |
Author
There was a problem hiding this comment.
@ltratt where did you get your mandelbrot benchmark from?
|
@ebarrett Do you want to update the comment in this PR? |
Author
|
I'll do it quickly now |
Author
|
Updated. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This slows down mandelbrot, but speeds up "bigloop"-like benchmarks and CLBG fannkuch Python3 ykjit#8. fannkuch Python3 ykjit#8 speeds up by about 40%. This makes us about over 2x upstream micropython on that benchmark. https://benchmarksgame-team.pages.debian.net/benchmarksgame/program/fannkuchredux-python3-8.html
Author
|
Fixed CI failure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This slows down mandelbrot, but speeds up "bigloop"-like benchmarks and CLBG fannkuch Python3 #8.
fannkuch Python3 #8 speeds up by about 40%.
This makes us about over 2x upstream micropython on that benchmark.
https://benchmarksgame-team.pages.debian.net/benchmarksgame/program/fannkuchredux-python3-8.html