Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds compatibility with GLPI 11.x while keeping support for GLPI 10.0.5+.
Changes (GLPI 11 / Symfony-related)
canCreate(): bool,getTypeName(): string) to match GLPI 11.$DB->queryOrDie()withMigration::addPreQuery()/addPostQuery()for table creation and notification updates (GLPI 11 "Executing direct queries is not allowed").$DB->request('table', $criteria)updated to$DB->request(['FROM' => 'table', 'WHERE' => $criteria]); raw SQL converted to array syntax where needed.addslashes/Toolbox::addslashes_deep(handled by GLPI 11).$CFG_GLPI['asset_types']; optionalplugin_behaviors_check_prerequisites(); guardeddropFieldwithfieldExists.includes.php; replacedHtml::displayErrorAndDie()with message +Html::back().__DIR__for requires; DBConnection fallbacks for charset/collation.Tested on GLPI 11.x. Original authors: Remi Collet, Nelly Mahu-Lasson.