Skip to content

Conversation

@kalisp
Copy link
Member

@kalisp kalisp commented Dec 18, 2025

Changelog Description

Added description of source version to destination version to provide additional information, mostly original author as that information is not passed over as it might require administrator permissions in case when user who is copying version is different from author.

image

Additional info

It was decided that separate permission to overwrite author might not be safest option.

Testing notes:

  1. push any version to Library project
  2. check its Description

Links copied version to original with author information. Author is not passed on version as it might require admin privileges.
@kalisp kalisp self-assigned this Dec 18, 2025
@kalisp kalisp added type: enhancement Improvement of existing functionality or minor addition sponsored This is directly sponsored by a client or community member labels Dec 18, 2025
@ynbot ynbot added the size/XS label Dec 18, 2025
@ynbot ynbot moved this to Review In Progress in PR reviewing Dec 18, 2025
@iLLiCiTiT
Copy link
Member

iLLiCiTiT commented Dec 18, 2025

Does this mean we can remove author in create_version?

kalisp and others added 3 commits December 19, 2025 11:21
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
@kalisp
Copy link
Member Author

kalisp commented Dec 19, 2025

Does this mean we can remove author in create_version?

It is removed here
https://github.com/ynput/ayon-core/pull/1621/changes#diff-be5409636e4a4f60baef5ddc16adc8bbc8635054bd032fda5451bfa66881cd20L1051

@kalisp kalisp requested a review from iLLiCiTiT December 19, 2025 10:27
@github-project-automation github-project-automation bot moved this from Review In Progress to Merge Requested in PR reviewing Dec 19, 2025
@iLLiCiTiT iLLiCiTiT merged commit b6b2726 into develop Dec 19, 2025
4 checks passed
@iLLiCiTiT iLLiCiTiT deleted the enhancement/YN-0290_provide_source_version_description branch December 19, 2025 15:21
@github-project-automation github-project-automation bot moved this from Merge Requested to Done in PR reviewing Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/XS sponsored This is directly sponsored by a client or community member type: enhancement Improvement of existing functionality or minor addition

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

YN-0290: Create permission to control version creation from different user

4 participants