Integrate Hero: Use FileTransaction in integrate plugin #1622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalisp
approved these changes
Dec 22, 2025
Member
kalisp
left a comment
kalisp
left a comment
There was a problem hiding this comment.
Still works.
BTW Argument 'product_base_type' is not provided to 'get_publish_template_name'. Could be handled in different PR though.
Member
Author
Yes, different PR. |
iLLiCiTiT
deleted the
bugfix/902-ay-3875_ayon-integrate-hero-for-review
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog Description
Integrate hero versions is using
FileTransactionto handle copying of files.Additional info
FileTransactionhandles more than what integrate hero version did. It also uses thread pool, but it also validates if the destination paths are re-used for multiple files which helps to avoid cryptic bugs reporting that the file is alredy used.Testing notes:
{output}from hero publish template).