Skip to content

Conversation

@BigRoy
Copy link
Contributor

@BigRoy BigRoy commented Jan 20, 2025

Changelog Description

Load GPU cache with the AYON metadata imprinted directly onto the GPU cache shape node. This allows duplicating, deleting and instancing the GPU cache nodes as an artist usually whilst AYON would continue to be able to track it.

Additional review information

Because the gpuCache node already has an attribute called representation this meant that for this 'imprinting' to be allowed that the attributes were required to be prefixed with AYON_ to avoid clashes. Which means that listing loaded containers now requires looking for both the AYON_id and id attributes.

Testing notes:

  1. Loading GPU caches should work
  2. Managing GPU caches should work (incl. legacy GPU caches)
  3. Check whether publishing e.g. layouts still work as intended, as they might be expecting an additional 'root' group node
  4. Check whether publishing works with input links being detected correctly

@BigRoy BigRoy added type: enhancement Improvement of existing functionality or minor addition community Issues and PRs coming from the community members labels Jan 20, 2025
@BigRoy BigRoy self-assigned this Jan 20, 2025
@moonyuet
Copy link
Member

moonyuet commented Apr 8, 2025

Tested in my side. Looks good. Is there anything else needed to be done before resolving conflict and finishing this PR?
image

Copy link
Member

@LiborBatek LiborBatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nevermind seems like broken scene...works when in different shot.

Im getting error when trying to produce pointcache publish from my animation scene

fails on extract pointcache with:

Traceback (most recent call last):
  File "C:\Users\lbate\AppData\Local\Ynput\AYON\dependency_packages\ayon_2406251801_windows.zip\dependencies\pyblish\plugin.py", line 528, in __explicit_process
    runner(*args)
  File "c:\Work\REPO\ayon-maya\client\ayon_maya\plugins\publish\extract_pointcache.py", line 253, in process
    extract_alembic(**kwargs)
  File "c:\Work\REPO\ayon-maya\client\ayon_maya\api\alembic.py", line 340, in extract_alembic
    cmds.AbcExport(
  File "C:\Program Files\Ynput\AYON 1.1.0\extract_pointcache", line 2, in AbcExport
RuntimeError: No valid root nodes were specified.

@LiborBatek
Copy link
Member

Loading and Manage functions works (for both older products and newly published ones), the only weird thing been that count say 2 even tho just single asset was loaded...

Screenshot 2025-04-09 105059

@BigRoy
Copy link
Contributor Author

BigRoy commented Apr 9, 2025

Haha, you all seem to really want this PR. It's still in draft.

Anyway, thanks for the notes. I guess you just had some spare time? ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community Issues and PRs coming from the community members type: enhancement Improvement of existing functionality or minor addition

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants