fix: TOProcessor#process の report_error 引数ミスを修正#76
Open
Conversation
report_error の第2引数は severity（デフォルト Logger::WARN）だが、 context（Context オブジェクト）が渡されていたためログレベルが UNKNOWN になっていた。 他の全 Processor と同様に report_error(e) と1引数で呼ぶように修正。 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
以下のケースをカバー: - 正常な TO レコードの処理 - マスタに存在しないコードの場合のダミー生成 - report_error が Logger::WARN で呼ばれることの検証 - TO レコード以外の入力に対する例外 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
yokenzan
force-pushed
the
fix/to-processor-report-error-arg
branch
from
34782fb to
bfe95c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
report_error(e, context)と呼んでいたが、report_errorの第2引数はseverity（デフォルトLogger::WARN）context（Context オブジェクト）が severity として渡され、ログレベルが UNKNOWN になっていたreport_error(e)と1引数で呼ぶよう修正Test plan
bundle exec rspecで全テスト通過を確認🤖 Generated with Claude Code