Conversation
|
Thanks @Blackjacx! There were some issues in master and tests weren't running. Could you please rebase off current master |
|
Alright, that's done 👍 I built the spec again and now this PR has only half of the changes!? |
|
Hey there, did you find the time to look into it? Generating the ASC API would be a massive time saver for me :D Tell me if I can do something. |
|
Did it work for you @Blackjacx? Cause I tried to build it and got same errors as without this PR changes (and CI check indicates the same errors) |
|
The happen when I run The API model has an attribute called which is not a string. Ca I change this behavior via templates? |
|
Hmm your update looks good @yonaskolb but did the CI run again? It looks like it reports the same errors. I compiled the new version locally. Now the following JSON produces incorrect value (maybe this is also an error in the spec - I donw understand why they specify "AppCategoryResponse" : {
"type" : "object",
"title" : "AppCategoryResponse",
"properties" : {
"data" : {
"$ref" : "#/components/schemas/AppCategory"
},
"included" : {
"type" : "array",
"items" : {
"oneOf" : [ {
"$ref" : "#/components/schemas/AppCategory"
}, {
"$ref" : "#/components/schemas/AppCategory"
} ]
}
},
"links" : {
"$ref" : "#/components/schemas/DocumentLinks"
}
},
"required" : [ "data", "links" ]
}The result is then: public class AppCategoryResponse: APIModel {
[...]
public var included: [Included]?But it should probably be: public class AppCategoryResponse: APIModel {
[...]
public var included: [AppCategory]? |
I added and build the Apple App Store Connect spec.
Resolves #248 - App Store Connect Open API Spec Doesn't Compile