libcontainer: Skip cgroup creation for rootless containers with cgroupfs #3146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating cgroups with cgroupfs as non-root is not possible. Before this change, we used to enforce systemd as a cgroup manager for all rootless containers, but that prevents the usage of rootless youki on systems wuthout systemd. To make such usage possible, raise a warning and skip cgroup-related activities instead. That matches the behavior of crun (containers/crun#97). Fixes youki-dev#3144 Signed-off-by: Michal Rostecki <vadorovsky@disroot.org>
vadorovsky
force-pushed
the
cgroupfs-rootless-warning
branch
from
e918f58 to
d8198be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating cgroups with cgroupfs as non-root is not possible. Before this change, we used to enforce systemd as a cgroup manager for all rootless containers, but that prevents the usage of rootless youki on systems wuthout systemd. To make such usage possible, raise a warning and skip cgroup-related activities instead. That matches the behavior of crun (containers/crun#97).
Description
Type of Change
Testing
Related Issues
Fixes #3144
Additional Context