add parse capabilities for duration on event command #3214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdaffad
force-pushed
the
enhancing-runc-compatibility-for-interval-on-event
branch
from
9ec332e to
b10c7aa
Compare
Collaborator
|
Hey, can you rebase and fix the clippy issues? Thanks :) |
Contributor
Author
|
Updated |
Member
|
@mdaffad Please sign following the instructions in the link |
utam0k
reviewed
Aug 12, 2025
crates/liboci-cli/src/events.rs
Outdated
|
|
||
| let num = num.parse::<u64>().map_err(|_| "Invalid number")?; | ||
|
|
||
| let dur = match unit.as_str() { |
mdaffad
force-pushed
the
enhancing-runc-compatibility-for-interval-on-event
branch
from
e246d2c to
b165eae
Compare
Signed-off-by: Muhammad Daffa Dinaya <muhammaddaffadinaya@gmail.com>
Signed-off-by: Muhammad Daffa Dinaya <muhammaddaffadinaya@gmail.com>
Signed-off-by: Muhammad Daffa Dinaya <muhammaddaffadinaya@gmail.com>
Signed-off-by: Muhammad Daffa Dinaya <muhammaddaffadinaya@gmail.com>
Signed-off-by: Muhammad Daffa Dinaya <muhammaddaffadinaya@gmail.com>
Signed-off-by: Muhammad Daffa Dinaya <muhammaddaffadinaya@gmail.com>
mdaffad
force-pushed
the
enhancing-runc-compatibility-for-interval-on-event
branch
from
b165eae to
2214ff1
Compare
Member
|
@mdaffad May I ask you to address DCO? |
utam0k
reviewed
Aug 26, 2025
| keywords = ["youki", "container", "oci"] | ||
|
|
||
| [dependencies] | ||
| parse_duration = "2.1.1" |
Member
There was a problem hiding this comment.
Can't we implement it ourselves?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Testing
Related Issues
Close #3206
Additional Context