Add poststart_fail hook test #3313
Open
+174
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavel Safronov <pv.safronov@gmail.com>
60 tasks
Contributor
Author
|
Hey @YJDoc2 Can you help me with containerd-integration-tests failure? It fails on I can't see how it could be related to the change I made here. |
Member
|
As you said, this PR only changes test code, so the containerd-test error is unrelated. |
saku3
reviewed
Dec 14, 2025
Member
saku3
left a comment
saku3
left a comment
There was a problem hiding this comment.
Thank you for the PR.
Overall, it looks good to me, but I left two comments.
Could you please take a look?
Signed-off-by: Pavel Safronov <pv.safronov@gmail.com>
Contributor
Author
|
I've addressed the comments, but one of the tests timed out. Pretty sure it is not related to my change, so will be happy if someone can trigger a re-run. |
saku3
approved these changes
Dec 26, 2025
utam0k
reviewed
Dec 29, 2025
Member
|
LGTM w/ one nit |
Signed-off-by: Pavel Safronov <pv.safronov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This implements a test similar to https://github.com/opencontainers/runtime-tools/blob/master/validation/poststart_fail/poststart_fail.go as a part of the #361
Type of Change
Testing
Related Issues
#361
Additional Context
The test is similar to the happy case test landed in #3292 but it focuses on the error handling.
I made it a bit different to the original go test to make sure we also test a couple of more things. I create three hooks, with the second hook failing. We expect that the first two hooks to run and exit with an error. The hook after the failed hook should not run as implied by the lifecycle spec https://github.com/opencontainers/runtime-spec/blob/main/runtime.md#lifecycle.
One assumption I make here is that the hooks are executed in the same order they're defined in a spec, which is not explicitly stated anywhere in the runtime spec but anyway I think it is a relatively safe assumption and it is nice to guarantee this order even if the spec doesn't require it.
Also, this test is affected by the same bug as a happy case scenario opencontainers/runc#4347 so an extra branch has been added to handle the incorrect runc behaviour.