Skip to content

Hidden user name#2

Open
hatappi wants to merge 6 commits intoyujiosaka:masterfrom
hatappi:hidden-user-name
Open

Hidden user name#2
hatappi wants to merge 6 commits intoyujiosaka:masterfrom
hatappi:hidden-user-name

Conversation

@hatappi
Copy link

@hatappi hatappi commented Mar 7, 2017

Hello.

I am using the same ID for github and slack.

team.json is below.

{
  "@hatappi": "<@hatappi>"
}

When commenting on GitHub, mention my account.
because sender's name is included in notification content.

2017-03-07 20 57 35

I looked for way user name is not notified, but I could not find it.
As a solution, added option to hide user name.

Test Environment

Hubot on Heroku

  • use hidden-user-name=1 parameter

image

  • not use hidden-user-name=1 parameter

image

@hatappi
Copy link
Author

hatappi commented Mar 7, 2017

@yujiosaka
Please check my PR 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants