Don't require an owned value for property setters.#1189
Don't require an owned value for property setters.#1189emilio wants to merge 1 commit intoz-galaxy:mainfrom
Conversation
| interface_name: InterfaceName<'_>, | ||
| property_name: &str, | ||
| value: Value<'_>, | ||
| value: &Value<'_>, |
There was a problem hiding this comment.
Unfortunately, this will be a breaking change since this is a public API. :(
There was a problem hiding this comment.
Hmm, ok, lmk if / how you want to deal with it and I can update the patch. Alternatively feel free to just close this (or tag it as deferred or whatever you want :))
There was a problem hiding this comment.
I'll just tag it I guess. I hope you're around to rebase when 6.0 is being released. :)
There was a problem hiding this comment.
Oh I just realised something: we can add another method here, that does what we need and then have the existing method use that one.
I'm thinking of adding a more generic method though that interface impl can use directly..
There was a problem hiding this comment.
I'm thinking of adding a more generic method though that interface impl can use directly..
Ok, nm this part for now (#1361). However, I think a new method will help get around the API break.
I wrote this as I was thinking about z-galaxy#1180, but not sure it's worth the complexity. If you think there are some other things that might use it, please go ahead and merge it, otherwise feel free to close :)
emilio
force-pushed
the
no-clone-value
branch
from
d146753 to
577de75
Compare
|
I addressed the (somewhat pedantic) clippy lint :) |
2 participants
I wrote this as I was thinking about #1180, but not sure it's worth the complexity. If you think there are some other things that might use it, please go ahead and merge it, otherwise feel free to close :)