Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion go/dagger.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "go",
"engineVersion": "v0.18.12",
"engineVersion": "v0.18.14",
"sdk": {
"source": "go"
},
Expand Down
27 changes: 15 additions & 12 deletions go/generate.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ package main

import (
"context"
"errors"
"fmt"
"slices"
"strings"
Expand Down Expand Up @@ -59,32 +60,34 @@ func (g *Generate) Report(ctx context.Context) ([]string, error) {
}

// Validate no change to the filesystem after running all generate directives.
func (g *Generate) Diff(ctx context.Context) (*dagger.Directory, error) {
func (g *Generate) Diff(ctx context.Context) error {
before := g.Ctr.Directory("/src")

cmds, err := g.Report(ctx)
if err != nil {
return nil, err
return err
}
fmt.Println(strings.Join(cmds, "\n"))

after := g.Ctr.Directory("/src")

beforeDigest, err := before.Digest(ctx)
if err != nil {
return nil, err
}

afterDigest, err := after.Digest(ctx)
stdout, err := dag.Container().
From("alpine").
WithExec([]string{"apk", "add", "diffutils"}).
WithMountedDirectory("/before", before).
WithMountedDirectory("/after", after).
WithExec([]string{"diff", "-r", "-y", "--suppress-common-lines", "/before", "/after"}).
Stdout(ctx)
if err != nil {
return nil, err
return err
}

if beforeDigest == afterDigest {
return dag.Directory(), nil
fmt.Println(stdout)
if stdout != "" {
return errors.New("generate resulted in difference before and after")
}

return before.Diff(after), nil
return nil
}

// Return all generate directives which would be ran.
Expand Down
17 changes: 1 addition & 16 deletions go/library.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ package main
import (
"context"
"errors"
"fmt"

"dagger/go/internal/dagger"
)
Expand Down Expand Up @@ -94,21 +93,7 @@ func (lib *Library) Generate(
// +default="./..."
pkg string,
) error {
diff, err := lib.Module.Generate(pkg).Diff(ctx)
if err != nil {
return err
}

entries, err := diff.Entries(ctx)
if err != nil {
return nil
}

if len(entries) > 0 {
return fmt.Errorf("forgot to run go generate: %v", entries)
}

return nil
return lib.Module.Generate(pkg).Diff(ctx)
}

// Validate no necessary changes for go.mod or go.sum.
Expand Down
2 changes: 1 addition & 1 deletion go/tests/dagger.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "go-tests",
"engineVersion": "v0.18.12",
"engineVersion": "v0.18.14",
"sdk": {
"source": "go"
},
Expand Down