[Hometask_7] docker#65
Open
SergeyLadutko wants to merge 4 commits intozadeploy:masterfrom
SergeyLadutko:Hometask_7
Open
[Hometask_7] docker#65SergeyLadutko wants to merge 4 commits intozadeploy:masterfrom SergeyLadutko:Hometask_7
SergeyLadutko wants to merge 4 commits intozadeploy:masterfrom
SergeyLadutko:Hometask_7
Conversation
anatoliliotych
suggested changes
May 4, 2020
Contributor
anatoliliotych
left a comment
anatoliliotych
left a comment
There was a problem hiding this comment.
please, check comments. In general looks good. Minor comments
Sergey_Ladutko/docker-compose-loadbalanser-nginx/docker-compose.yml
Outdated
Show resolved
Hide resolved
Sergey_Ladutko/docker-compose-loadbalanser-nginx/docker-compose.yml
Outdated
Show resolved
Hide resolved
Sergey_Ladutko/docker-compose-loadbalanser-nginx/docker-compose.yml
Outdated
Show resolved
Hide resolved
Sergey_Ladutko/docker-compose-loadbalanser-nginx/loadbalansernginxconf/nginx.conf
Outdated
Show resolved
Hide resolved
anatoliliotych
suggested changes
May 4, 2020
Contributor
anatoliliotych
left a comment
anatoliliotych
left a comment
There was a problem hiding this comment.
more small comments :)
Sergey_Ladutko/docker-compose-loadbalanser-nginx/loadbalanсernginxconf/nginx.conf
Outdated
Show resolved
Hide resolved
Sergey_Ladutko/docker-compose-loadbalanser-nginx/loadbalanсernginxconf/nginx.conf
Outdated
Show resolved
Hide resolved
Sergey_Ladutko/docker-compose-loadbalanser-nginx/docker-compose.yml
Outdated
Show resolved
Hide resolved
anatoliliotych
suggested changes
May 5, 2020
Contributor
anatoliliotych
left a comment
anatoliliotych
left a comment
There was a problem hiding this comment.
https://chris.beams.io/posts/git-commit/ please, check. this is really useful and differ you from others.
Sergey_Ladutko/docker-compose-loadbalanser-nginx/docker-compose.yml
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.