Return original HTTP attributes from webflux ServerHttpRequest #2181
+112
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current implementation of
ServerRequestfromorg.zalando.logbook.spring.webfluxreturns an empty attribute map, regardless of whether any attributes are present (seeHttpRequest).This improvement exposes the Spring server request attributes through
ServerRequest.getAttributes().Motivation and Context
In a Spring Boot application, I would like to pass a
userIdinside aWebFilterusingHttpAttributes, and then later retrieve this value inLogbookWebFiltervia anAttributeExtractorin order to include it in the logs. However, in my current setup, theHttpAttributesare always empty when accessed through the extractor.See: zalando/logbook#2175
Types of changes
Checklist: