Uncompress compressed body before return #2192
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antsyganov
requested review from
ChristianLohmann,
kasmarian,
lukasniemeier-zalando and
msdousti
as code owners
antsyganov
force-pushed
the
decompresing_response_for_httpclient5
branch
from
e0c0b71 to
d077404
Compare
antsyganov
force-pushed
the
decompresing_response_for_httpclient5
branch
from
d077404 to
10df24b
Compare
kasmarian
reviewed
Dec 19, 2025
| @ConditionalOnMissingBean(org.zalando.logbook.httpclient5.LogbookHttpResponseInterceptor.class) | ||
| public org.zalando.logbook.httpclient5.LogbookHttpResponseInterceptor logbookHttpClient5ResponseInterceptor() { | ||
| return new org.zalando.logbook.httpclient5.LogbookHttpResponseInterceptor(); | ||
| public org.zalando.logbook.httpclient5.LogbookHttpResponseInterceptor logbookHttpClient5ResponseInterceptor(@Value("${logbook.httpclient5.decompress-response:false}") final boolean decompressResponse) { |
Member
There was a problem hiding this comment.
Please add the declaration of the new property to spring-configuration-metadata.json and README.
| static class HttpClient5AutoConfiguration { | ||
|
|
||
| @Bean | ||
| @ConditionalOnMissingBean(org.zalando.logbook.httpclient5.LogbookHttpRequestInterceptor.class) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The byte[] getBody() method decompresses the body before returning it. It checks if the response contains a Content-Encoding header with the value gzip or x-gzip. If so, the method decompresses the body before returning it. As a result, Logbook will print the decompressed content, instead of displaying unreadable compressed data such as �0���=W��Q.... This ensures that the logged output is human-readable.
Motivation and Context
If the response body is compressed, calling new String(getBody(), getCharset()) will cause Logbook to treat the body as plain text (or JSON), rather than as compressed bytes. As a result, Logbook will print unreadable compressed data such as �0���=W��Q....
Types of changes
Checklist: