Fix multiprocessing Pool shutdown issue on Python 3.13+#249
Merged
Conversation
5fa84f5 to
28a99a1
Compare
Create the pool separately and skip it for single-threaded runs (threads=1). Attach the pool reference to the sampler and explicitly close/join it after run_sampler finishes, preventing the OSError "Bad file descriptor" that occurs when Pool.__del__ fires on an already-closed pipe. Closes #245
28a99a1 to
a1b3e59
Compare
8a2d787 to
c9b5792
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OSError: [Errno 9] Bad file descriptorthat occurs on Python 3.13+ when the multiprocessingPoolcreated inget_sampleris garbage-collected without being properly shut downthreads=1), passingpool=Noneto emcee (which runs serially)_naima_pooland explicitly callsclose()/join()afterrun_samplercompletesCloses #245