Fix affected_rows data source for ON DUPLICATE KEY UPDATE operations #885
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
affected_rowsalways returned0forON DUPLICATE KEY UPDATEoperations in Trilogy adapter.Root Cause: In this PR, we had used
raw_connection.affected_rowswhich returns stale/incorrect values for ON DUPLICATE KEY UPDATE in Trilogy.The correct values are available in
result.affected_rowsfrom the execute result object, so this simply changes the implementation to make use of the result rather than the connection to fetch theaffected_rows, super simple change.This PR:
Switch from
raw_connection.affected_rowstoresult.affected_rowswhen availablePreserve
nilfor adapters without supportAdds a test to cover for that edge case
Fix batch accumulation to handle nil values properly