Skip to content

improve toHaveCount assertion messages #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mher21 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

improve toHaveCount assertion messages #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/playwright/src/mcp/browser/tools/helperFunctions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -896,7 +896,7 @@ export function getAssertionMessage(assertionType: string, elementDescription: s
toMatchAriaSnapshotOptions: `'${elementDescription}' has different ARIA structure (should match snapshot with options).`,
toContainClass: `'${elementDescription}' is missing class (class should be present).`,
toHaveClass: `'${elementDescription}' has different classes (exact class match required).`,
toHaveCount: `'${elementDescription}' has different count (specific count required).`,
toHaveCount: `The number of '${elementDescription}' does not equal the expected value.`,
toHaveCSS: `'${elementDescription}' has different CSS property value (specific value required).`,
toHaveId: `'${elementDescription}' has different id (specific id required).`,
toHaveJSProperty: `'${elementDescription}' has different JS property value (specific value required).`,
Expand Down Expand Up @@ -928,7 +928,7 @@ export function getAssertionMessage(assertionType: string, elementDescription: s
toMatchAriaSnapshotOptions: `'${elementDescription}' matches ARIA structure with options (should have different structure).`,
toContainClass: `'${elementDescription}' has the class (should not have it).`,
toHaveClass: `'${elementDescription}' has matching classes (should have different classes).`,
toHaveCount: `'${elementDescription}' has matching count (should have different count).`,
toHaveCount: `The number of '${elementDescription}' equals the expected value, but it should be different.`,
toHaveCSS: `'${elementDescription}' has matching CSS property value (should have different value).`,
toHaveId: `'${elementDescription}' has matching id (should have different id).`,
toHaveJSProperty: `'${elementDescription}' has matching JS property value (should have different value).`,
Expand Down Expand Up @@ -1064,7 +1064,7 @@ export function getAssertionEvidence(
},
toHaveCount: (args) => {
const count = args?.count !== undefined ? args.count : 'count';
return `'${elementDescription}' count ${negate ? 'does not equal' : 'equals'} ${count} `;
return `'${elementDescription}' count ${negate ? 'does not equal' : 'equals'} ${count} as expected`;
},
toHaveCSS: (args) => {
const cssName = args?.name || 'property';
Expand Down