WIP Better union representation for Swift #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arithmetic operators in Swift are not allowed to overflow by default. Use overflow operators when calculating the hash value to prevent overflow errors.
Swift has enumerations with associated values, which seems like a natural representation of union structs. WIP: untested and needs better errors in some cases.
stigsb
force-pushed
the
ZEDGE
branch
2 times, most recently
from
760eb29 to
beeea56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swift has enumerations with associated values, which seems like a
natural representation of union structs.
This would convert a union as
union Foo {
1: Bar bar
2: Baz baz
}
into a Swift definition like
enum Foo {
case bar(Bar)
case baz(Baz)
case ThriftUnknownValue
}
WIP: untested and needs better errors in some cases.