Open
Conversation
Closed
Report for GZLE01 (9cc61c4 - 102141b)📈 Matched code: 57.00% (+0.06%, +4500 bytes) ✅ 62 new matches
...and 32 more new matches Report for GZLJ01 (9cc61c4 - 102141b)📈 Matched code: 55.32% (+0.06%, +4500 bytes) ✅ 62 new matches
...and 32 more new matches Report for GZLP01 (9cc61c4 - 102141b)📈 Matched code: 55.27% (+0.06%, +4500 bytes) ✅ 62 new matches
...and 32 more new matches Report for D44J01 (9cc61c4 - 102141b)📈 Matched code: 44.60% (+0.06%, +4356 bytes) ✅ 61 new matches
...and 31 more new matches 📈 1 improvement in unmatched functions
|
LagoLunatic
reviewed
Jan 6, 2026
Collaborator
LagoLunatic
left a comment
LagoLunatic
left a comment
There was a problem hiding this comment.
FYI, if you're having trouble with matching some specific parts you can ask for help in the discord. Partial review with some things I noticed:
src/d/actor/d_a_tag_kf1.cpp
Outdated
|
|
||
| /* 000010E0-00001100 .text daTag_Kf1_Delete__FP11daTag_Kf1_c */ | ||
| static BOOL daTag_Kf1_Delete(daTag_Kf1_c* i_this) { | ||
| static bool daTag_Kf1_Delete(daTag_Kf1_c* i_this) { |
Collaborator
There was a problem hiding this comment.
These static funcs should always return BOOL not bool. You can get the clrlwi to appear/disappear by changing the return types of the inner functions (e.g. _delete) instead.
src/d/actor/d_a_tag_kf1.cpp
Outdated
Comment on lines
+28
to
+30
| // this line should def load from a_prm_tbl according to asm, | ||
| // but unlike the others the type is not float so do this gross cast instead | ||
| f0x10 = *(u8*)(void*)&a_prm_tbl[2]; |
Collaborator
There was a problem hiding this comment.
a_prm_tbl needs to be a struct, not an array of floats. You can define a custom struct here to match it.
Also, the name being a_prm_tbl$4033 tells you to put the static var inside of the function - $ means an in-function static.
src/d/actor/d_a_tag_kf1.cpp
Outdated
Comment on lines
+38
to
+39
| daObj::PrmAbstract<daTsubo::Act_c::Prm_e>(act, daTsubo::Act_c::PRM_TYPE_W, | ||
| daTsubo::Act_c::PRM_TYPE_S) == 0xe) { |
Collaborator
There was a problem hiding this comment.
Use daTsubo::Act_c's prm_chk_type_kutani inline
src/d/actor/d_a_tag_kf1.cpp
Outdated
| void daTag_Kf1_c::setStt(signed char) { | ||
| char daTag_Kf1_c::setStt(signed char c) { | ||
| stt = c; | ||
| if (stt == 3) { |
Collaborator
There was a problem hiding this comment.
You can match the weird cmpwi here by doing a switch statement on stt that doesn't do anything.
For future reference, if you're having trouble with a function like this, you can ask for help in the discord by posting a scratch: https://github.com/zeldaret/tww/blob/main/docs/decompiling.md#asking-for-help-with-a-function-by-sharing-a-decompme-scratch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Equivalent, appears to only mismatch on data offset.