Open
Conversation
…g, but XyEvent_cB is weird and I'm entirely sure how it works.
…hat have me stumped
… weird with the inlining but createinit is doing a lot of weird stuff and i cant really figure it out lol
…matching aside from execute which is mostly matching
Report for GZLP01 (3bd775e - 1e7505f)📈 Matched code: 41.04% (+0.01%, +828 bytes) ✅ 11 new matches:
📈 1 improvements in unmatched functions:
|
Report for GZLJ01 (3bd775e - 1e7505f)📈 Matched code: 40.07% (+0.01%, +828 bytes) ✅ 11 new matches:
📈 1 improvements in unmatched functions:
|
Report for D44J01 (3bd775e - 1e7505f)📈 Matched code: 29.71% (+0.01%, +544 bytes) ✅ 9 new matches:
📈 3 improvements in unmatched functions:
|
Report for GZLE01 (3bd775e - 1e7505f)📈 Matched code: 41.54% (+0.01%, +828 bytes) ✅ 11 new matches:
📈 1 improvements in unmatched functions:
|
ammaraskar
reviewed
Jun 14, 2025
| public: | ||
| /* Place member variables here */ | ||
| }; | ||
| /* 0x290 */ s16 field_0x290; |
Contributor
There was a problem hiding this comment.
Given the way this gets accessed, this should probably be typed as an array of a single short: s16 field_0x290[1]
| /* Nonmatching */ | ||
| int r3 = -1; | ||
| if (dComIfGp_event_runCheck() != FALSE && !eventInfo.checkCommandTalk()) | ||
| r3 = dComIfGp_evmng_getMyStaffId("TagBa1", NULL, 0); |
Contributor
There was a problem hiding this comment.
You can omit the NULL and 0, those are the default values if those arguments aren't passed in.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All functions matching except for
daTag_Ba1_c::_executewhich is mostly matching but has some weird gameinfo loads.