Open
Conversation
Report for GZLP01 (27f0df1 - e6f8731)📈 Matched code: 52.89% (+0.08%, +6040 bytes) ✅ 44 new matches
...and 14 more new matches Report for D44J01 (27f0df1 - e6f8731)📈 Matched code: 42.08% (+0.08%, +6128 bytes) ✅ 44 new matches
...and 14 more new matches Report for GZLJ01 (27f0df1 - e6f8731)📈 Matched code: 52.98% (+0.08%, +6036 bytes) ✅ 44 new matches
...and 14 more new matches Report for GZLE01 (27f0df1 - e6f8731)📈 Matched code: 54.26% (+0.08%, +6040 bytes) ✅ 44 new matches
...and 14 more new matches |
LagoLunatic
reviewed
Sep 14, 2025
Comment on lines
+41
to
+45
| const f32 daHmlif_c::m_cull_box[][6] = { | ||
| {-200.0f, -100.0f, -200.0f, 200.0f, 50.0f, 200.0f}, | ||
| {-200.0f, -100.0f, -200.0f, 200.0f, 450.0f, 200.0f}, | ||
| {-200.0f, -100.0f, -200.0f, 200.0f, 450.0f, 200.0f}, | ||
| }; |
Collaborator
There was a problem hiding this comment.
Does this still match when changed to an array of fopAc_cullSizeBox? Like in f_op_actor_mng.cpp
Contributor
Author
There was a problem hiding this comment.
Nope, that makes initialisation runtime.
Collaborator
There was a problem hiding this comment.
Oh I see, in that case it should be Vec[][2] like d_a_windmill.
Comment on lines
+516
to
+517
| static cPhs_State daHmlif_Create(void* v_this) { | ||
| return ((daHmlif_c*)v_this)->daHmlifCreate(); |
Collaborator
There was a problem hiding this comment.
Does v_this mean something? It doesn't appear in the assertion strings for either TWW or TP.
Contributor
Author
There was a problem hiding this comment.
It's the void version of this, if we have a_this for the actor version, and i_this for the input one, I just decided to use v_this for the void version.
Collaborator
There was a problem hiding this comment.
It's still an input parameter so i_this seems right here. The devs tend to name the actor input parameter i_this regardless of whether its class is fopAc_ac_c* or a subclass so they probably do for void* as well.
Collaborator
|
Was there an issue with using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #216.