Migrate Easy components #126
Conversation
| // PaginationLast | ||
| // ============================================================================ | ||
|
|
||
| export interface PaginationLastProps extends React.ButtonHTMLAttributes<HTMLButtonElement> {} |
There was a problem hiding this comment.
Here are quite a few typescript errors still
| goToLast: () => void; | ||
| } | ||
|
|
||
| export function usePagination({ |
There was a problem hiding this comment.
I would probably put this to a separate file, and not export it from the component file itself
| import { cn } from "../../utilities"; | ||
|
|
||
| export const numberboxVariants = cva( | ||
| "flex h-10 w-10 items-center justify-center rounded-sm text-text-lg font-semibold", |
There was a problem hiding this comment.
I think the dimensions are not exactly the same as the ones we do have right now. Especially width and height.
| @@ -0,0 +1,106 @@ | |||
| import * as React from "react"; | |||
| import { cva, VariantProps } from "class-variance-authority"; | |||
There was a problem hiding this comment.
There are unused ts imports, variables, etc... in here.
Please also make sure there is some responsive behavior in here. Probably using a container query can make sense I guess. But at somepoint there needs ot be a wrap I feel like
| // EmptyStateActions - Container for action buttons | ||
| const emptyStateActionsVariants = cva("flex items-center justify-center gap-3"); | ||
|
|
||
| export interface EmptyStateActionsProps extends React.HTMLAttributes<HTMLDivElement> {} |
There was a problem hiding this comment.
again some ts errors.
Once you're done with it, I will need to check, so esp. spacing etc... match the design system
|
Before merging, we need to check #112 again, because a new radix dep gets added here |
Fixes Issue / Ticket
Description
✨ [Provide a brief description of the changes introduced by this pull request.]
Checklist
Please make sure that your pull request complies with the following requirements:
Code Quality:
Testing:
Documentation:
Review:
Security:
Screenshots (optional)
📸 [Include any relevant screenshots or visual representations of the changes.]
Additional Information
ℹ️ [Provide any additional information that might be useful for the reviewer.]