Skip to content

[OPS-547] Don't allow release and snapshot workflows to run concurrently#108

Draft
alourie wants to merge 1 commit intomainfrom
OPS-547-no-interrupt-running-action
Draft

[OPS-547] Don't allow release and snapshot workflows to run concurrently#108
alourie wants to merge 1 commit intomainfrom
OPS-547-no-interrupt-running-action

Conversation

@alourie
Copy link
Copy Markdown
Contributor

@alourie alourie commented Apr 9, 2026

Description

We had a couple of releases fail due to the snapshot and the release workflows running at the same time and messing with the git tree. This change groups the snapshot and release workflows into the same concurrency group, which only allows 1 workflow to execute at a time, placing another into a PENDING state while waiting for another workflow to finalise. The following is the type of message the waiting workflow (in this case, a release workflow) will get:

image

Signed-off-by: Alex Lourie <alex.lourie@zepben.com>
@ryanjcoleman
Copy link
Copy Markdown
Member

echo "There was an error in the mvn deploy command above."
echo "##########################################################################"
echo "# There was an error in the mvn deploy command above (Mvn Package Step) #"
echo "##########################################################################"
Copy link
Copy Markdown
Contributor Author

@alourie alourie Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eh, this sneaked in after playing with clearer error messages. I bet no one will notice.

@charlta
Copy link
Copy Markdown
Member

charlta commented Apr 10, 2026

question: Won't this still have the same problem?

t0: kick off snapshot with hash 1
t1: kick off release with hash 1 (paused)
t2: snapshot finished and updates main with release info (hash 2)
t2': resume release action via concurrency group, still pinned to hash 1
t3: release if pushed to maven, but fails to merge back to main due to conflict (with hash 2)

@charlta charlta marked this pull request as draft April 10, 2026 01:07
@alourie
Copy link
Copy Markdown
Contributor Author

alourie commented Apr 10, 2026

question: Won't this still have the same problem?

t0: kick off snapshot with hash 1 t1: kick off release with hash 1 (paused) t2: snapshot finished and updates main with release info (hash 2) t2': resume release action via concurrency group, still pinned to hash 1 t3: release if pushed to maven, but fails to merge back to main due to conflict (with hash 2)

That's a fair point, I'll run the tests to validate.

@alourie
Copy link
Copy Markdown
Contributor Author

alourie commented Apr 10, 2026

@charlta tested, you're correct. Need to come up with something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants