[DEV-7731] implement identifiable interface#218
Merged
Conversation
Member
|
Task linked: DEV-7731 Update Python SDK |
charlta
requested changes
Mar 23, 2026
Member
charlta
left a comment
There was a problem hiding this comment.
How much fun did you have trying to figure out what parts of the JVM SDK change you needed to pull across with the vastly different way the proto2cim stuff works? It was a PITA for me to review 😜
d05214e to
5c3979d
Compare
…` subclasses of ``Identifiable`` Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com> a Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com> make ``Name`` a subclass of identifiable Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com> bump zepben.protobuf to 1.4.0b4. and make work Function names, Type hints, docs, and much more are WRONG, but the code works. Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com> GrpcClient kinda done, could definitely refactor some of the child classes into this base to dedupe stuff Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com> BaseService, Differences and Comparator. Difference, ReferenceResolvers Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com> rename `add_to_network_or_none` to `add_to_service_or_none` as network is misleading and wrong. Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com> I think thats all. Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com> missed some stuff, docs on BaseService were all sorts of whack Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com> PR Changes Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com> fix type hinting in ServiceComparatorValidator Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com> sum hints bad, good now Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com> parameterise, and make pretty Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com> name.mrid and stuff Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>
Signed-off-by: Max Chesterfield <max.chesterfield@zepben.com>
Signed-off-by: Anthony Charlton <anthony.charlton@zepben.com>
Signed-off-by: Anthony Charlton <anthony.charlton@zepben.com>
5c3979d to
e3f28cf
Compare
…ate_reference_by_field` to `Identifiable` Signed-off-by: Anthony Charlton <anthony.charlton@zepben.com>
Signed-off-by: Anthony Charlton <anthony.charlton@zepben.com>
…`Identifiable` or `IdentifiedObject` Signed-off-by: Anthony Charlton <anthony.charlton@zepben.com>
Signed-off-by: Anthony Charlton <anthony.charlton@zepben.com>
Signed-off-by: Anthony Charlton <anthony.charlton@zepben.com>
…wasn't. Signed-off-by: Anthony Charlton <anthony.charlton@zepben.com>
…ving them when unused. Signed-off-by: Anthony Charlton <anthony.charlton@zepben.com>
f50c7c0 to
5eb05af
Compare
charlta
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Port over jvm sdk changes.
changes that snuck in:
add_to_network_or_nonetoadd_to_service_or_noneAssociated tasks
List any other tasks / PRs that are required to be merged alongside this one (e.g. front end task for back end change or vice versa). If a PR exists, add a link. If not, just add an appropriate note here so reviewers know there is a dependency and will hold off merging until all things are ready.
Test Steps
Explain in detail how your reviewer can test the changes proposed in this PR. If it cannot be tested, leave an explanation on why.
Checklist
If any of these are not applicable, strikethrough the line
~like this~. Do not delete it!. Let the reviewer decide if you should have done it.Code
Security
When developing applications, use following guidelines for information security considerations:
Documentation
Breaking Changes
Please leave a summary of the breaking changes here and then post it on the Slack breaking-changes channel to notify the team about it.