Force Exception if Compilation Fails #2456
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fenikkusu
force-pushed
the
hotfix/compile-errors
branch
from
6cf9f06 to
b5df467
Compare
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following:
Small description of change:
As part of the changes I was "attempting" with #2450, at one point, I added these changes. This was done because I was running the unit testing and getting errors that the extension couldn't be found. After digging into it, I realized that the backend
makecommand to compile was exiting with a non-zero status, but could not see it in the normal process of running the commands. This forces an exception in the event compilation fails, forcing thezephir compilecommand to exit with a non-zero exit status.